feat(CI): configure workflow for different OS#7253
Open
bijin-bruno wants to merge 10 commits intomainfrom
Open
feat(CI): configure workflow for different OS#7253bijin-bruno wants to merge 10 commits intomainfrom
bijin-bruno wants to merge 10 commits intomainfrom
Conversation
bijin-bruno
requested review from
helloanoop,
lohit-bruno and
naman-bruno
as code owners
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a configurable Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CLI Test Results (Windows) 1 files 183 suites 1m 13s ⏱️ For more details on these failures and errors, see this check. Results for commit 01e0e02. ♻️ This comment has been updated with latest results. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/actions/tests/run-cli-tests/action.yml:
- Around line 11-15: The "Run Local Testbench" step uses a trailing "&" to
background the npm start command which breaks when shell: ${{ inputs.shell }} is
pwsh; update the step so it doesn't rely on the Bash background operator: either
set this step's shell explicitly to bash (shell: bash) and keep the current run
block, or implement two conditional steps (one with shell: bash running "npm
start --workspace=packages/bruno-tests &; sleep 5", and one with shell: pwsh
that starts the testbench without using "&" (e.g., start-process or Start-Job /
Use Start-Process -NoNewWindow and wait) ensuring the pwsh variant does not
include the trailing "&"); target the "Run Local Testbench" step and the line
containing "npm start --workspace=packages/bruno-tests &" when making the
change.
In @.github/workflows/tests-macos.yml:
- Around line 17-61: Add the missing setup step that installs node_modules
before each macOS test job: insert a step that uses
./.github/actions/setup-node-deps immediately before the existing "Run Unit
Tests" step in the unit-test job and likewise before "Run CLI Tests" in cli-test
and before "Run E2E Tests" in e2e-test; ensure the step uses the same action
name (setup-node-deps) and placement as in the Linux workflow (no shell override
needed for macOS).
In @.github/workflows/tests-windows.yml:
- Around line 17-66: Add the missing setup-node-deps step to the Windows jobs so
dependencies and packages are installed/built before tests: insert the existing
setup-node-deps step (same as used in tests-linux) into the unit-test, cli-test,
and e2e-test jobs immediately before the steps named "Run Unit Tests", "Run CLI
Tests", and "Run E2E Tests" respectively; ensure each added setup-node-deps step
passes shell: pwsh to match the Windows runners.
- Around line 79-80: The "Setup Node Dependencies" step (uses:
./.github/actions/common/setup-node-deps) is missing the explicit Windows shell
setting; update that step to include "shell: pwsh" so it matches the other
Windows job steps and avoids relying on Git Bash—add the shell: pwsh property to
the step definition for consistency and clarity.
053c3a3 to
691b3b9
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/tests-macos.yml:
- Around line 98-99: The step name "Run Custom CA Certs E2E Tests" is misleading
for the action "./.github/actions/ssl/macos/run-ssl-e2e-tests"; rename the step
to accurately reflect the action (for example "Run SSL E2E Tests (macOS)" or
match the Linux counterpart naming) so the workflow step title and the action
invoked are consistent; update the name field in the workflow where the step
with uses "./.github/actions/ssl/macos/run-ssl-e2e-tests" is declared.
- Around line 25-47: The ci job "cli-test" is missing a timeout configuration
which can hang indefinitely; add the same timeout-minutes: 60 setting to the
cli-test job definition (the job named "cli-test" in the workflow) at the job
top-level so it matches the other jobs and the Linux workflow's cli-test,
ensuring the runner will terminate after 60 minutes if tests hang.
In @.github/workflows/tests-windows.yml:
- Around line 29-55: Add a job timeout to prevent hung CI: in the cli-test job
definition (symbol: cli-test) add timeout-minutes: 60 under the job-level
settings; also propagate the same change to the equivalent jobs in
tests-macos.yml and tests-linux.yml to keep behavior consistent across
platforms.
- Around line 83-109: The Windows ssl-test job is missing the "Setup Feature
Dependencies" step; add a step in the ssl-test job (inside
.github/workflows/tests-windows.yml) immediately before the existing "Setup CA
Certificates" step that uses the action
./.github/actions/ssl/windows/setup-feature-specific-deps (create that action if
it doesn’t exist), with a name like "Setup Feature Dependencies" so the Windows
flow matches tests-linux.yml and tests-macos.yml and ensures feature-specific
deps are installed before setup-ca-certs and subsequent Run *SSL* steps.
---
Duplicate comments:
In @.github/workflows/tests-macos.yml:
- Around line 17-23: Ensure each test job (unit-test, cli-test, e2e-test)
explicitly invokes the local action ./.github/actions/common/setup-node-deps
before its test action so dependencies are installed; update the job steps to
include a step that uses "uses: ./.github/actions/common/setup-node-deps"
immediately prior to the existing test step (e.g., before "uses:
./.github/actions/tests/run-unit-tests") to guarantee setup-node-deps runs for
unit-test, cli-test, and e2e-test.
In @.github/workflows/tests-windows.yml:
- Around line 19-27: The CI jobs were missing the preparatory step to install
Node dependencies and to set PowerShell as the shell; add a step that uses the
setup-node-deps action with with: shell: pwsh before each test action invocation
(e.g., before run-unit-tests, run-cli-tests, run-e2e-tests) in the unit-test,
cli-test, and e2e-test jobs so each job calls setup-node-deps (uses:
./.github/actions/common/setup-node-deps) with shell: pwsh prior to running the
test action.
.github/workflows/tests-macos.yml
Outdated
Comment on lines
+25
to
+47
| cli-test: | ||
| name: CLI Tests | ||
| runs-on: macos-latest | ||
| permissions: | ||
| checks: write | ||
| pull-requests: write | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - name: Setup Node Dependencies | ||
| uses: ./.github/actions/common/setup-node-deps | ||
|
|
||
| - name: Run CLI Tests | ||
| uses: ./.github/actions/tests/run-cli-tests | ||
|
|
||
| - name: Publish Test Report | ||
| uses: EnricoMi/publish-unit-test-result-action@v2 | ||
| if: always() | ||
| with: | ||
| check_name: CLI Test Results (macOS) | ||
| files: packages/bruno-tests/collection/junit.xml | ||
| comment_mode: always |
Contributor
There was a problem hiding this comment.
cli-test missing timeout-minutes.
All other jobs in this file have timeout-minutes: 60 but cli-test has none. A hung CLI test run would block the runner indefinitely. This is consistent with the Linux workflow's cli-test job, but worth fixing across both.
🐛 Proposed fix
cli-test:
name: CLI Tests
+ timeout-minutes: 60
runs-on: macos-latest📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| cli-test: | |
| name: CLI Tests | |
| runs-on: macos-latest | |
| permissions: | |
| checks: write | |
| pull-requests: write | |
| contents: read | |
| steps: | |
| - uses: actions/checkout@v6 | |
| - name: Setup Node Dependencies | |
| uses: ./.github/actions/common/setup-node-deps | |
| - name: Run CLI Tests | |
| uses: ./.github/actions/tests/run-cli-tests | |
| - name: Publish Test Report | |
| uses: EnricoMi/publish-unit-test-result-action@v2 | |
| if: always() | |
| with: | |
| check_name: CLI Test Results (macOS) | |
| files: packages/bruno-tests/collection/junit.xml | |
| comment_mode: always | |
| cli-test: | |
| name: CLI Tests | |
| timeout-minutes: 60 | |
| runs-on: macos-latest | |
| permissions: | |
| checks: write | |
| pull-requests: write | |
| contents: read | |
| steps: | |
| - uses: actions/checkout@v6 | |
| - name: Setup Node Dependencies | |
| uses: ./.github/actions/common/setup-node-deps | |
| - name: Run CLI Tests | |
| uses: ./.github/actions/tests/run-cli-tests | |
| - name: Publish Test Report | |
| uses: EnricoMi/publish-unit-test-result-action@v2 | |
| if: always() | |
| with: | |
| check_name: CLI Test Results (macOS) | |
| files: packages/bruno-tests/collection/junit.xml | |
| comment_mode: always |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/tests-macos.yml around lines 25 - 47, The ci job
"cli-test" is missing a timeout configuration which can hang indefinitely; add
the same timeout-minutes: 60 setting to the cli-test job definition (the job
named "cli-test" in the workflow) at the job top-level so it matches the other
jobs and the Linux workflow's cli-test, ensuring the runner will terminate after
60 minutes if tests hang.
Comment on lines
+98
to
+99
| - name: Run Custom CA Certs E2E Tests | ||
| uses: ./.github/actions/ssl/macos/run-ssl-e2e-tests No newline at end of file |
Contributor
There was a problem hiding this comment.
Step name doesn't match the action it invokes.
The step is named Run Custom CA Certs E2E Tests but uses ./.github/actions/ssl/macos/run-ssl-e2e-tests. If this action covers general SSL E2E tests (not just custom CA certs), the name is misleading. Consider aligning it with the macOS Linux counterpart (line 110–111 in tests-linux.yml).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/tests-macos.yml around lines 98 - 99, The step name "Run
Custom CA Certs E2E Tests" is misleading for the action
"./.github/actions/ssl/macos/run-ssl-e2e-tests"; rename the step to accurately
reflect the action (for example "Run SSL E2E Tests (macOS)" or match the Linux
counterpart naming) so the workflow step title and the action invoked are
consistent; update the name field in the workflow where the step with uses
"./.github/actions/ssl/macos/run-ssl-e2e-tests" is declared.
.github/workflows/tests-windows.yml
Outdated
Comment on lines
+29
to
+55
| cli-test: | ||
| name: CLI Tests | ||
| runs-on: windows-latest | ||
| permissions: | ||
| checks: write | ||
| pull-requests: write | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - name: Setup Node Dependencies | ||
| uses: ./.github/actions/common/setup-node-deps | ||
| with: | ||
| shell: pwsh | ||
|
|
||
| - name: Run CLI Tests | ||
| uses: ./.github/actions/tests/run-cli-tests | ||
| with: | ||
| shell: pwsh | ||
|
|
||
| - name: Publish Test Report | ||
| uses: EnricoMi/publish-unit-test-result-action/windows@v2 | ||
| if: always() | ||
| with: | ||
| check_name: CLI Test Results (Windows) | ||
| files: packages/bruno-tests/collection/junit.xml | ||
| comment_mode: always |
Contributor
There was a problem hiding this comment.
cli-test missing timeout-minutes — consistent with macOS and Linux, but still worth addressing. A hung CLI test run on Windows would block the runner indefinitely. Consider adding timeout-minutes: 60 here and in the equivalent jobs in tests-macos.yml and tests-linux.yml for consistency.
🐛 Proposed fix
cli-test:
name: CLI Tests
+ timeout-minutes: 60
runs-on: windows-latest🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/tests-windows.yml around lines 29 - 55, Add a job timeout
to prevent hung CI: in the cli-test job definition (symbol: cli-test) add
timeout-minutes: 60 under the job-level settings; also propagate the same change
to the equivalent jobs in tests-macos.yml and tests-linux.yml to keep behavior
consistent across platforms.
Comment on lines
+83
to
+109
| ssl-test: | ||
| name: SSL Tests | ||
| timeout-minutes: 60 | ||
| runs-on: windows-latest | ||
| permissions: | ||
| checks: write | ||
| pull-requests: write | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - name: Setup Node Dependencies | ||
| uses: ./.github/actions/common/setup-node-deps | ||
| with: | ||
| shell: pwsh | ||
|
|
||
| - name: Setup CA Certificates | ||
| uses: ./.github/actions/ssl/windows/setup-ca-certs | ||
|
|
||
| - name: Run Basic SSL CLI Tests | ||
| uses: ./.github/actions/ssl/windows/run-basic-ssl-cli-tests | ||
|
|
||
| - name: Run Custom CA Certs CLI Tests | ||
| uses: ./.github/actions/ssl/windows/run-custom-ca-certs-cli-tests | ||
|
|
||
| - name: Run Custom CA Certs E2E Tests | ||
| uses: ./.github/actions/ssl/windows/run-ssl-e2e-tests |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Explore the .github/actions directory structure for SSL-related actions
find .github/actions -type d -name ssl | head -20Repository: usebruno/bruno
Length of output: 77
🏁 Script executed:
#!/bin/bash
# Check what actions exist in the ssl directory structure
find .github/actions/ssl -type f -name "action.yml" | sortRepository: usebruno/bruno
Length of output: 900
🏁 Script executed:
#!/bin/bash
# Check the tests-linux.yml workflow around line 98-99
fd "tests-linux.yml" .github/workflows --exec cat {}Repository: usebruno/bruno
Length of output: 3073
🏁 Script executed:
#!/bin/bash
# Check the tests-macos.yml workflow around line 86-87
fd "tests-macos.yml" .github/workflows --exec cat {}Repository: usebruno/bruno
Length of output: 2593
Windows ssl-test is missing a "Setup Feature Dependencies" step present in both Linux and macOS equivalents.
Both tests-linux.yml (line 98-99) and tests-macos.yml (line 86-87) include a "Setup Feature Dependencies" step before setup-ca-certs. The Windows ssl-test workflow skips this entirely. To match the other platforms and ensure SSL tests run correctly on Windows, add a step calling ./.github/actions/ssl/windows/setup-feature-specific-deps (the action will need to be created if it doesn't exist yet).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/tests-windows.yml around lines 83 - 109, The Windows
ssl-test job is missing the "Setup Feature Dependencies" step; add a step in the
ssl-test job (inside .github/workflows/tests-windows.yml) immediately before the
existing "Setup CA Certificates" step that uses the action
./.github/actions/ssl/windows/setup-feature-specific-deps (create that action if
it doesn’t exist), with a name like "Setup Feature Dependencies" so the Windows
flow matches tests-linux.yml and tests-macos.yml and ensures feature-specific
deps are installed before setup-ca-certs and subsequent Run *SSL* steps.
691b3b9 to
01e0e02
Compare
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/actions/common/setup-node-deps/action.yml (1)
8-11: LGTM — clean, backward-compatible shell parameterisation.Default of
bashkeeps existing callers untouched, and the description clearly documents the accepted values. One optional hardening: GitHub Actions composite actions don't validate enum inputs, so an unsupported shell value (e.g.,sh,cmd) will silently fail mid-run with a cryptic error. Consider adding a guard step if the number of consumers grows.🛡️ Optional: explicit shell guard step
inputs: shell: description: 'Shell to use (bash, pwsh)' required: false default: 'bash' + + # Guard — add before the first run: step + steps: + - name: Validate shell input + if: ${{ inputs.shell != 'bash' && inputs.shell != 'pwsh' }} + shell: bash + run: | + echo "Unsupported shell '${{ inputs.shell }}'. Allowed: bash, pwsh" + exit 1🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/actions/common/setup-node-deps/action.yml around lines 8 - 11, The 'shell' input in action.yml currently defaults to 'bash' but isn't validated; add an early guard step in the composite action that reads the 'shell' input (the shell input named "shell") and verifies it is one of the supported values (e.g., 'bash' or 'pwsh'), and if not, fail fast with a clear error message; implement this as a lightweight run/step at the top of the action to prevent cryptic mid-run failures and reference the 'shell' input when producing the error.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/actions/common/setup-node-deps/action.yml:
- Around line 8-11: The 'shell' input in action.yml currently defaults to 'bash'
but isn't validated; add an early guard step in the composite action that reads
the 'shell' input (the shell input named "shell") and verifies it is one of the
supported values (e.g., 'bash' or 'pwsh'), and if not, fail fast with a clear
error message; implement this as a lightweight run/step at the top of the action
to prevent cryptic mid-run failures and reference the 'shell' input when
producing the error.
CLI Test Results (macOS) 1 files 183 suites 1m 4s ⏱️ Results for commit 01e0e02. |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/tests-macos.yml:
- Around line 41-44: The e2e-test job is missing an explicit permissions block
which causes it to inherit repo defaults; add a permissions mapping to the
e2e-test job (job name "e2e-test") that mirrors the minimal scope used by the
other jobs (for example setting contents: read, actions: read, id-token: write
or whichever minimal set the repository uses) so the job follows least-privilege
and matches the other jobs' permissions pattern.
---
Duplicate comments:
In @.github/workflows/tests-macos.yml:
- Around line 90-91: The job step name "Run Custom CA Certs E2E Tests" is
misleading relative to the invoked action
"./.github/actions/ssl/macos/run-ssl-e2e-tests"; update the step name to
accurately reflect the broader SSL e2e action (e.g., "Run SSL E2E Tests" or "Run
SSL macOS E2E Tests") so the step label matches the action being executed;
locate the step that contains the uses entry
"./.github/actions/ssl/macos/run-ssl-e2e-tests" and rename its name field
accordingly.
- Around line 25-27: The cli-test job is missing a timeout setting so it can
hang indefinitely; update the job definition for cli-test to include a
timeout-minutes value (use 60 to match other jobs) by adding the
timeout-minutes: 60 key under the cli-test job block so the workflow enforces
the same 60-minute timeout as the other jobs.
Comment on lines
+41
to
+44
| e2e-test: | ||
| name: Playwright E2E Tests | ||
| timeout-minutes: 60 | ||
| runs-on: macos-latest |
Contributor
There was a problem hiding this comment.
e2e-test is missing a permissions block.
All three other jobs (unit-test, cli-test, ssl-test) explicitly declare permissions. This job silently inherits the workflow/repo defaults, which may be broader than intended and diverges from the least-privilege pattern applied elsewhere.
🐛 Proposed fix — mirrors the minimum scope used by other jobs
e2e-test:
name: Playwright E2E Tests
timeout-minutes: 60
runs-on: macos-latest
+ permissions:
+ contents: read
steps:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/tests-macos.yml around lines 41 - 44, The e2e-test job is
missing an explicit permissions block which causes it to inherit repo defaults;
add a permissions mapping to the e2e-test job (job name "e2e-test") that mirrors
the minimal scope used by the other jobs (for example setting contents: read,
actions: read, id-token: write or whichever minimal set the repository uses) so
the job follows least-privilege and matches the other jobs' permissions pattern.
0b5a07f to
ad2c51d
Compare
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (2)
.github/workflows/tests-windows.yml (2)
84-101:⚠️ Potential issue | 🟠 Major
ssl-testis still missing a "Setup Feature Dependencies" step present in both the Linux and macOS equivalents.Both
tests-linux.yml(Line 90–91) and the macOS workflow include a step calling./.github/actions/ssl/<os>/setup-feature-specific-depsbeforesetup-ca-certs. Without it, feature-specific dependencies may not be in place when CA certs are configured and the SSL tests run.🐛 Proposed fix (create the action if it doesn't exist yet)
- name: Setup Node Dependencies uses: ./.github/actions/common/setup-node-deps with: shell: pwsh + - name: Setup Feature Dependencies + uses: ./.github/actions/ssl/windows/setup-feature-specific-deps - name: Setup CA Certificates uses: ./.github/actions/ssl/windows/setup-ca-certs🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/tests-windows.yml around lines 84 - 101, Add the missing "Setup Feature Dependencies" step to the Windows SSL workflow: insert a step that uses ./.github/actions/ssl/windows/setup-feature-specific-deps (same as Linux/macOS) immediately before the "Setup CA Certificates" step so feature-specific dependencies are installed prior to CA cert configuration and the subsequent "Run Basic SSL CLI Tests"/"Run Custom CA Certs CLI Tests"/"Run Custom CA Certs E2E Tests" steps; if that action does not yet exist, create it mirroring the linux/macos implementation.
29-31:⚠️ Potential issue | 🟡 Minor
cli-testis still missingtimeout-minutes— a hung run will block the Windows runner indefinitely.🐛 Proposed fix
cli-test: name: CLI Tests (Windows) + timeout-minutes: 60 runs-on: windows-latest🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/tests-windows.yml around lines 29 - 31, The ci job "cli-test" is missing a timeout-minutes setting which can cause a hung run to block the Windows runner; add a timeout-minutes property under the cli-test job definition (the "cli-test" job entry in the workflow) with an appropriate value (e.g., 10 or another org-standard timeout) so the job will be cancelled automatically after that duration; ensure the key is at the same indentation level as name and runs-on within the cli-test job.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/workflows/tests-windows.yml:
- Around line 84-101: Add the missing "Setup Feature Dependencies" step to the
Windows SSL workflow: insert a step that uses
./.github/actions/ssl/windows/setup-feature-specific-deps (same as Linux/macOS)
immediately before the "Setup CA Certificates" step so feature-specific
dependencies are installed prior to CA cert configuration and the subsequent
"Run Basic SSL CLI Tests"/"Run Custom CA Certs CLI Tests"/"Run Custom CA Certs
E2E Tests" steps; if that action does not yet exist, create it mirroring the
linux/macos implementation.
- Around line 29-31: The ci job "cli-test" is missing a timeout-minutes setting
which can cause a hung run to block the Windows runner; add a timeout-minutes
property under the cli-test job definition (the "cli-test" job entry in the
workflow) with an appropriate value (e.g., 10 or another org-standard timeout)
so the job will be cancelled automatically after that duration; ensure the key
is at the same indentation level as name and runs-on within the cli-test job.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
.github/actions/common/setup-node-deps/action.yml.github/actions/ssl/linux/run-ssl-e2e-tests/action.yml.github/actions/ssl/macos/run-ssl-e2e-tests/action.yml.github/actions/ssl/windows/run-ssl-e2e-tests/action.yml.github/actions/tests/run-cli-tests/action.yml.github/actions/tests/run-e2e-tests/action.yml.github/actions/tests/run-unit-tests/action.yml.github/workflows/ssl-tests.yml.github/workflows/tests-linux.yml.github/workflows/tests-macos.yml.github/workflows/tests-windows.ymlpackages/bruno-tests/collection/scripting/node-builtins/node-path.bru
💤 Files with no reviewable changes (2)
- packages/bruno-tests/collection/scripting/node-builtins/node-path.bru
- .github/workflows/ssl-tests.yml
🚧 Files skipped from review as they are similar to previous changes (4)
- .github/workflows/tests-macos.yml
- .github/actions/tests/run-cli-tests/action.yml
- .github/actions/common/setup-node-deps/action.yml
- .github/actions/tests/run-unit-tests/action.yml
bijin-bruno
force-pushed
the
feat/playwright-os
branch
4 times, most recently
from
270094e to
c7b6596
Compare
bijin-bruno
force-pushed
the
feat/playwright-os
branch
2 times, most recently
from
43b6236 to
e2cddbb
Compare
bijin-bruno
force-pushed
the
feat/playwright-os
branch
from
e2cddbb to
cd1611c
Compare
bijin-bruno
force-pushed
the
feat/playwright-os
branch
from
1c7d8ec to
b23ee5c
Compare
|
CLI Test Results (Linux) 1 files 190 suites 58s ⏱️ Results for commit 34192c6. ♻️ This comment has been updated with latest results. |
bijin-bruno
force-pushed
the
feat/playwright-os
branch
2 times, most recently
from
ed13369 to
25799e5
Compare
bijin-bruno
force-pushed
the
feat/playwright-os
branch
from
25799e5 to
565d381
Compare
* fix: update system proxy fetching to use finally for improved reliability * Update packages/bruno-electron/src/index.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bijin-bruno
force-pushed
the
feat/playwright-os
branch
from
565d381 to
51a1f43
Compare
bijin-bruno
force-pushed
the
feat/playwright-os
branch
from
51a1f43 to
34192c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Configure workflow for different OS
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
Summary by CodeRabbit
Tests
Chores